Repository navigation
fix(milestones): remove released issues from the allocations map - #637
Closed
yggdrasilworld wants to merge 2 commits into
Closed
yggdrasilworld wants to merge 2 commits into
yggdrasilworld wants to merge 2 commits into
Conversation
release_issue marked the issue Released and paid out, but left the entry in milestone.allocations — the map grew into a phantom ledger where 'allocated' no longer meant outstanding. Remove it on release (remaining_budget was already reduced at allocate-time, so it's untouched here). Resolves MergeFi#608
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
…es allocation removal; rewire orphaned test imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What — phantom ledger drift
release_issuemarked the issue Released + paid out, but left the entry inmilestone.allocations— the map grew into a phantom ledger where 'allocated' no longer meant outstanding.Fix
Remove the entry on release. (
remaining_budgetwas already reduced at allocate-time, so it's correctly untouched.)Resolves #608
Payment: Base USDC
0xD40Df5c27cEa7dd78A3c345401995c319589334e